Gidi Kroon

gidi@friendica.gidikroon.eu

TV addict, science fiction enthusiast, proud inhabitant of Earth (our only home).

Trying to show support for films, tv series, actresses and musicians I admire. Posting some tech and politics in between.

There's nothing wrong with fighting for social justice. Black Lives Matter. Gender equality. Fight for a sustainable use of environmental resources.

Posts by me are published cc-by, so they may be shared, boosted, reposted, reblogged, retweeted, etc. Posts and/or photos by others that I share remain copyright by the respective owners. Posts by me are searchable in the opt-in index of tootfinder. This profile is discoverable on the opt-in fediverse.info people directory (#fedi22).

My tags for services that don't support or see profile keywords:
#film, #movies, #music, #tv, #photography, #scifi, #actresses, #fandom, #science, #physics, #astronomy, #electronics, #programming, #technology, #android, #politics, #news, #environment

People I'm likely posting about:
Jenna Ortega, Dove Cameron, Miranda Cosgrove, Stephanie Leonidas, Jodie Foster, Alizée, Dafne Keen, Alexa Nisenson, Bella Gantt, Katie Douglas, Ciara Bravo, Amy-Leigh Hickman

Network Posts

Netherlands

https://gidikroon.eu/

Gidi Kroon

8 months ago •

Gidi Kroon
8 months ago •

!Friendica Developers
Hi, I have been looking into link previews and especially why a PeerTube video preview image (when the video is linked to in a Friendica post) doesn't update on Friendica after it has been updated on PeerTube. The main reason I found was that PeerTube doesn't set any cache-control headers or expire headers on its dynamic content, just the 'etag'. I think I can deal with that within PeerTube's nginx.

But I also found that Friendica stores the parsed site info from the url in the database, for a full 3 months (in such cases), without allowing it to be evicted earlier from that cache. In fact the logic seems to be:

If parsing the site info fails, store that failure for 1 day before trying again
If no max-age is present on the cache control header returned by the site, store the parsed info for 3 months. This value is not configurable. (Also applies if

!Friendica Developers

Friendica Developers reshared this.

in reply to Gidi Kroon

Gidi Kroon

in reply to Gidi Kroon • 8 months ago •

I've been running with these hardcoded changes for a few days on a single user instance and it works fine. The highest expire date in the parsed_url table was in the year 4044; I decided not to wait for that and emptied the whole table a few days ago.

code of screenshot

diff --git a/src/Util/ParseUrl.php b/src/Util/ParseUrl.php
index 79f427a65..d56bf992b 100644
--- a/src/Util/ParseUrl.php
+++ b/src/Util/ParseUrl.php
@@ -42,8 +42,12 @@ use Friendica\Network\HTTPClient\Client\HttpClientOptions;
  */
 class ParseUrl
 {
-       const DEFAULT_EXPIRATION_FAILURE = 'now + 1 day';
-       const DEFAULT_EXPIRATION_SUCCESS = 'now + 3 months';
+        // Temporarily change by Gidi Kroon 20230816
+       //const DEFAULT_EXPIRATION_FAILURE = 'now + 1 d

code of screenshot

diff --git a/src/Util/ParseUrl.php b/src/Util/ParseUrl.php
index 79f427a65..d56bf992b 100644
--- a/src/Util/ParseUrl.php
+++ b/src/Util/ParseUrl.php
@@ -42,8 +42,12 @@ use Friendica\Network\HTTPClient\Client\HttpClientOptions;
  */
 class ParseUrl
 {
-       const DEFAULT_EXPIRATION_FAILURE = 'now + 1 day';
-       const DEFAULT_EXPIRATION_SUCCESS = 'now + 3 months';
+        // Temporarily change by Gidi Kroon 20230816
+       //const DEFAULT_EXPIRATION_FAILURE = 'now + 1 day';
+       //const DEFAULT_EXPIRATION_SUCCESS = 'now + 3 months';
+       const DEFAULT_EXPIRATION_FAILURE = 'now + 1 hour';
+       const DEFAULT_EXPIRATION_SUCCESS = 'now + 1 hour';
+        const MAX_EXPIRATION_SECONDS = 60 * 60 * 24;
 
        /**
         * Maximum number of characters for the description
@@ -248,6 +252,8 @@ class ParseUrl
                if ($cacheControlHeader = $curlResult->getHeader('Cache-Control')[0] ?? '') {
                        if (preg_match('/max-age=([0-9]+)/i', $cacheControlHeader, $matches)) {
                                $maxAge = max(86400, (int)array_pop($matches));
+                               // Temporarily added min() by Gidi Kroon 20230816
+                               $maxAge = min(MAX_EXPIRATION_SECONDS, $maxAge);
                                $siteinfo['expires'] = DateTimeFormat::utc("now + $maxAge seconds");
                        }
                }

For a single user instance it is rare to see the same post more than an hour later. But also when looking at older posts I don't notice any problems. For me there is no reason to keep the data of other sites for 3 months (without even checking for changes) and even when set to 1 hour, it is still less load on the other sites then when I would be browsing them directly as one user. I think that at least for single user instances, these can be considered as defaults as well.

Friendica Developers reshared this.

⇧